Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging somewhat #737

Merged
merged 6 commits into from Jan 28, 2017
Merged

Conversation

DustinCampbell
Copy link
Contributor

No description provided.

@filipw
Copy link
Member

filipw commented Jan 28, 2017

This is a very welcome change - thank you - especially as logging has been in quite a disarray.

This reminds me of two things for the future:

  • since we will now have the capability of externally configuring the logging level it will be a good idea to generally revise the logging usage throughout the application. For example a lot of current "Information" logs could be downgraded and so on
  • one of the bigger problems IMHO has been that in many cases, on server errors, the log would only show "error 500, ErrorMiddleware" and that's it (unless you enabled verbose level). This should also be addressed as it will help a lot

@DustinCampbell
Copy link
Contributor Author

Agreed on both points. I'd like to get both done so the logging is sensible. I also have a change for VS Code logging once this goes in to make it look much more like the Console logger, reducing a lot of noise.

@filipw filipw merged commit b24c48f into OmniSharp:dev Jan 28, 2017
@DustinCampbell DustinCampbell deleted the clean-up-logging branch February 2, 2017 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants