New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cake support #932

Merged
merged 40 commits into from Oct 25, 2017

Conversation

Projects
None yet
5 participants
@mholo65
Collaborator

mholo65 commented Aug 2, 2017

Opening PR to get feedback.

Omnisharp.Cake piggybacks on OmniSharp.Roslyn.CSharp services, but will intercept and handle buffer updates before sending them to C# services... This is how it works.

  1. We have this custom tool Bakery which is doing Cake script analysis and CodeGen
  2. When OmniSharp starts up, a bakery process is started and a communication channel is opened between omnisharp.exe and cake.bakery.exe
  3. Whenever a buffer update occurs for a *.cake file it is sent to the bakery process in order to get analysed and a Roslyn compatible script is returned.
  4. The roslyn compatible script is added to the buffer manager and so on....

All feedback is welcome! @david-driscoll @DustinCampbell @filipw

here is a small example project if you like to test it out. Please note that Cake.Bakery (which can be fetched from our MyGet feed) needs to be located in the workspace before starting OmniSharp. It should be located in the tools folder. E.g. ${workspaceRoot}/tools/ folder or any other folder specified in cake.config.

Will send accompanying PR in Omnisharp-VSCode repo soon.

TODO:

  • Don't hardcode Cake.Bakery.exe path to $(toolsdir)/Cake.Bakery/tools/Cake.Bakery.exe
  • Fix lineoffsets when loading nested .cake files
  • Add documentation provider when loading addins
  • Load downloaded addins added after server was started
  • Add Unit Tests
  • Add integration tests
  • Cleanup

@mholo65 mholo65 referenced this pull request Aug 2, 2017

Merged

[WIP] Cake support #1681

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Aug 2, 2017

Collaborator

omnisharp-cake

Here's a small preview.

Collaborator

mholo65 commented Aug 2, 2017

omnisharp-cake

Here's a small preview.

Show outdated Hide outdated NuGet.Config
Show outdated Hide outdated src/OmniSharp.Cake/Configuration/CakeConfiguration.cs
var value = tokens.Current.Value;
if (ContainsWhiteSpace(value))
{
throw new InvalidOperationException("Sections cannot contain whitespace.");

This comment has been minimized.

@david-driscoll

david-driscoll Oct 7, 2017

Member

What does cake do in this scenario, does it throw if the config has invalid values or does it default those values?

@david-driscoll

david-driscoll Oct 7, 2017

Member

What does cake do in this scenario, does it throw if the config has invalid values or does it default those values?

This comment has been minimized.

@mholo65

mholo65 Oct 8, 2017

Collaborator

Configuration handling is "copy-pasted-with-pride" from the Cake repo. Now that I look at it, I should remove any exception throwing and just set sensible defaults.

@mholo65

mholo65 Oct 8, 2017

Collaborator

Configuration handling is "copy-pasted-with-pride" from the Cake repo. Now that I look at it, I should remove any exception throwing and just set sensible defaults.

This comment has been minimized.

@david-driscoll

david-driscoll Oct 9, 2017

Member

A second set of 👀 always helps!

@david-driscoll

david-driscoll Oct 9, 2017

Member

A second set of 👀 always helps!

This comment has been minimized.

@mholo65

mholo65 Oct 10, 2017

Collaborator

I went the Catch-and-Log route instead. Makes more sense than silently continue and keeps code in sync with code in Cake.

@mholo65

mholo65 Oct 10, 2017

Collaborator

I went the Catch-and-Log route instead. Makes more sense than silently continue and keeps code in sync with code in Cake.

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Oct 18, 2017

Contributor

FWIW, Travis CI failed on Linux. It looks like a real test failure in the Cake unit tests.

Examples:

39;49m�[31m    OmniSharp.Cake.Tests.AutoCompleteFacts.ShouldGenerateFromHostObject [FAIL]
�[39;49m�[37m      System.NullReferenceException : Object reference not set to an instance of an object
�[39;49m�[30m      Stack Trace:
�[39;49m�[37m          at OmniSharp.Cake.Services.CakeScriptService.Generate (Cake.Scripting.Abstractions.Models.FileChange fileChange) [0x00001] in <c4e6a1d4b56f401e87edf025a609f888>:0 
�[39;49m�[37m          at OmniSharp.Cake.Services.RequestHandlers.Buffer.UpdateBufferHandler+<Handle>d__3.MoveNext () [0x0016f] in <c4e6a1d4b56f401e87edf025a609f888>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.AutoCompleteFacts+<FindCompletionsAsync>d__5.MoveNext () [0x00273] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.AutoCompleteFacts+<ShouldGenerateFromHostObject>d__4.MoveNext () [0x00072] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[31m    OmniSharp.Cake.Tests.LineIndexHelperFacts.TranslateToGenerated_Should_Translate_Index_In_Single_File(index: 0, expected: 8208) [FAIL]
�[39;49m�[37m      System.InvalidOperationException : Could not load manifest resource stream.
�[39;49m�[30m      Stack Trace:
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts.GetResourceContent (System.String resourceName) [0x00017] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts.GetGeneratedFileContent (System.String name) [0x00016] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts+<TranslateToGenerated_Should_Translate_Index_In_Single_File>d__12.MoveNext () [0x0001a] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
Contributor

DustinCampbell commented Oct 18, 2017

FWIW, Travis CI failed on Linux. It looks like a real test failure in the Cake unit tests.

Examples:

39;49m�[31m    OmniSharp.Cake.Tests.AutoCompleteFacts.ShouldGenerateFromHostObject [FAIL]
�[39;49m�[37m      System.NullReferenceException : Object reference not set to an instance of an object
�[39;49m�[30m      Stack Trace:
�[39;49m�[37m          at OmniSharp.Cake.Services.CakeScriptService.Generate (Cake.Scripting.Abstractions.Models.FileChange fileChange) [0x00001] in <c4e6a1d4b56f401e87edf025a609f888>:0 
�[39;49m�[37m          at OmniSharp.Cake.Services.RequestHandlers.Buffer.UpdateBufferHandler+<Handle>d__3.MoveNext () [0x0016f] in <c4e6a1d4b56f401e87edf025a609f888>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.AutoCompleteFacts+<FindCompletionsAsync>d__5.MoveNext () [0x00273] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.AutoCompleteFacts+<ShouldGenerateFromHostObject>d__4.MoveNext () [0x00072] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[31m    OmniSharp.Cake.Tests.LineIndexHelperFacts.TranslateToGenerated_Should_Translate_Index_In_Single_File(index: 0, expected: 8208) [FAIL]
�[39;49m�[37m      System.InvalidOperationException : Could not load manifest resource stream.
�[39;49m�[30m      Stack Trace:
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts.GetResourceContent (System.String resourceName) [0x00017] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts.GetGeneratedFileContent (System.String name) [0x00016] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m          at OmniSharp.Cake.Tests.LineIndexHelperFacts+<TranslateToGenerated_Should_Translate_Index_In_Single_File>d__12.MoveNext () [0x0001a] in <a83d90541b74416a88991defa1662a99>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m        --- End of stack trace from previous location where exception was thrown ---
�[39;49m�[37m          at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x0000c] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (System.Threading.Tasks.Task task) [0x0003e] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (System.Threading.Tasks.Task task) [0x00028] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (System.Threading.Tasks.Task task) [0x00008] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
�[39;49m�[37m          at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <c9f8153c41de4f8cbafd0e32f9bf6b28>:0 
@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Oct 18, 2017

Collaborator

@DustinCampbell yes, it feels like some problem using cake.bakery.exe on Linux within the unit tests. Will try to spin up the old virtual machine and give it a go later tonight.

Collaborator

mholo65 commented Oct 18, 2017

@DustinCampbell yes, it feels like some problem using cake.bakery.exe on Linux within the unit tests. Will try to spin up the old virtual machine and give it a go later tonight.

@mholo65 mholo65 changed the title from [WIP] Cake support to Cake support Oct 22, 2017

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Oct 22, 2017

Collaborator

@david-driscoll @filipw @DustinCampbell removed [WIP] tag now 😉

Collaborator

mholo65 commented Oct 22, 2017

@david-driscoll @filipw @DustinCampbell removed [WIP] tag now 😉

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Oct 24, 2017

Contributor

I just took a look at the changes to launch cake.bakery.exe. Looks good to me!

Contributor

DustinCampbell commented Oct 24, 2017

I just took a look at the changes to launch cake.bakery.exe. Looks good to me!

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Oct 24, 2017

Collaborator

@DustinCampbell nice! I’ll just fix @filipw’s comments then. @david-driscoll do you have anything to add?

Collaborator

mholo65 commented Oct 24, 2017

@DustinCampbell nice! I’ll just fix @filipw’s comments then. @david-driscoll do you have anything to add?

@david-driscoll

This comment has been minimized.

Show comment
Hide comment
@david-driscoll

david-driscoll Oct 24, 2017

Member

Nothing else from me.

Member

david-driscoll commented Oct 24, 2017

Nothing else from me.

@filipw

This comment has been minimized.

Show comment
Hide comment
@filipw

filipw Oct 24, 2017

Member

Out of curiosity, why do some files have a header:

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

are they copied from somewhere?

Member

filipw commented Oct 24, 2017

Out of curiosity, why do some files have a header:

// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

are they copied from somewhere?

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Oct 24, 2017

Collaborator

@filipw, yes. They are copied from Cake, which is licensed under MIT license. We didn’t want OmniSharp to take on a dependency on Cake.Core and therefore it’ copied. It should only be the configuration bits.

Collaborator

mholo65 commented Oct 24, 2017

@filipw, yes. They are copied from Cake, which is licensed under MIT license. We didn’t want OmniSharp to take on a dependency on Cake.Core and therefore it’ copied. It should only be the configuration bits.

@DustinCampbell

This comment has been minimized.

Show comment
Hide comment
@DustinCampbell

DustinCampbell Oct 24, 2017

Contributor

Per the comment, shouldn't we include the MIT License in the folder with these files? I did the same thing for OmniSharp.DotNet.ProjectModel after copying all of the code over from the .NET CLI.

Contributor

DustinCampbell commented Oct 24, 2017

Per the comment, shouldn't we include the MIT License in the folder with these files? I did the same thing for OmniSharp.DotNet.ProjectModel after copying all of the code over from the .NET CLI.

@mholo65

This comment has been minimized.

Show comment
Hide comment
@mholo65

mholo65 Oct 24, 2017

Collaborator

Sure, I can do that!

Collaborator

mholo65 commented Oct 24, 2017

Sure, I can do that!

@gep13

This comment has been minimized.

Show comment
Hide comment
@gep13

gep13 Oct 25, 2017

Great work @mholo65!

Can't wait to get this merged in, and start to roll it out!

gep13 commented Oct 25, 2017

Great work @mholo65!

Can't wait to get this merged in, and start to roll it out!

@filipw

filipw approved these changes Oct 25, 2017

:shipit:

@filipw

This comment has been minimized.

Show comment
Hide comment
@filipw

filipw Oct 25, 2017

Member

Since everyone signed off, I will merge it 🎉

Member

filipw commented Oct 25, 2017

Since everyone signed off, I will merge it 🎉

@filipw filipw merged commit 329d28a into OmniSharp:master Oct 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment