Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwritten some global options #34

Closed
thinca opened this issue May 14, 2013 · 3 comments
Closed

Overwritten some global options #34

thinca opened this issue May 14, 2013 · 3 comments

Comments

@thinca
Copy link
Member

thinca commented May 14, 2013

Some global options and plugin settings are overwritten by this plugin.

These are set by user, so plugin should not change these.
You can recommend to user by document.
@nosami
Copy link
Contributor

nosami commented May 14, 2013

Yeah... that's a fair point. I was just trying to make it as simple as possible to get up and running.

I'll remove these and put them in the docs.

@nosami nosami closed this as completed in c3ac402 May 15, 2013
@thinca
Copy link
Member Author

thinca commented May 15, 2013

You forgot 'noshowmatch'.

@nosami nosami mentioned this issue May 15, 2013
Closed
nosami added a commit that referenced this issue May 15, 2013
@nosami
fixes #34 Don't set global settings within plugin
86b3d50
@nosami
Copy link
Contributor

nosami commented May 15, 2013

Good catch. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thinca @nosami