Skip to content

Commit

Permalink
fix: remove "Ideas for new ideas" section from Report List (#1195)
Browse files Browse the repository at this point in the history
* remove "Ideas for new ideas" from reportList
  • Loading branch information
sebesti0n committed Apr 13, 2024
1 parent f8bdfa5 commit af5e1ae
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,23 +134,13 @@ public void onItemClick(AdapterView<?> adapterView, View view, int i, long l) {
getString(R.string.analytics_problem),
getString(R.string.analytics_label_app_feedback_without_location));
}
} else if (getString(R.string.rt_ideas).equals(rti.getTitle())) {
// Direct to ideascale website
goToIdeaScale();
ObaAnalytics.reportUiEvent(mFirebaseAnalytics,
getString(R.string.analytics_problem),
getString(R.string.analytics_label_idea_scale));
}
}

private void goToCustomerServices() {
((ReportActivity) getActivity()).createCustomerServiceFragment();
}

private void goToIdeaScale() {
UIUtils.goToUrl(getActivity(), getString(R.string.ideascale_url));
}

private Boolean isOpen311Active() {
ObaRegion currentRegion = Application.get().getCurrentRegion();
Boolean isOpen311Active = Boolean.FALSE;
Expand Down
6 changes: 0 additions & 6 deletions onebusaway-android/src/main/res/values-es/arrays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -143,46 +143,40 @@
<item>@string/rt_infrastructure_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>
<string-array name="report_types_desc">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_infrastructure_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_types_without_open311">
<item>@string/rt_customer_service</item>
<item>@string/rt_stop_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>

<string-array name="report_types_desc_without_open311">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_stop_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons_without_open311">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_stop_issue_tutorial_desc">
Expand Down
2 changes: 0 additions & 2 deletions onebusaway-android/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -684,13 +684,11 @@
<string name="rt_stop_problem_title">Problema de Parada</string>
<string name="rt_arrival_problem_title">Problema de Tiempo de Llegada</string>
<string name="rt_app_feedback">Enviar Comentarios de la App</string>
<string name="rt_ideas">Ideas para Nuevas Funciones</string>
<string name="rt_message_infrastructure_problem">Ruta faltante, banco roto, etc.</string>
<string name="rt_message_customer_service">Felicitaciones o Quejas al conductor, objetos perdidos, etc.</string>
<string name="rt_message_stop_problem">Ruta faltante, mal nombre de la parada, etc.</string>
<string name="rt_message_arrival_problem">El vehículo nunca llegó, mal tiempo de llegada, etc.</string>
<string name="rt_message_app_feedback">Diseño, errores, etc.</string>
<string name="rt_message_ideas">Enviar y votar sobre las futuras mejoras</string>
<string name="rt_address_hint">Dirección del problema (opcional)</string>
<string name="rt_yes">SI</string>
<string name="rt_no">NO</string>
Expand Down
6 changes: 0 additions & 6 deletions onebusaway-android/src/main/res/values-it/arrays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -142,46 +142,40 @@
<item>@string/rt_infrastructure_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>
<string-array name="report_types_desc">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_infrastructure_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_types_without_open311">
<item>@string/rt_customer_service</item>
<item>@string/rt_stop_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>

<string-array name="report_types_desc_without_open311">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_stop_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons_without_open311">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_stop_issue_tutorial_desc">
Expand Down
2 changes: 0 additions & 2 deletions onebusaway-android/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -590,13 +590,11 @@
<string name="rt_stop_problem_title">Problema con fermata</string>
<string name="rt_arrival_problem_title">Problema con orario d\'arrivo</string>
<string name="rt_app_feedback">Invia feedback sull\'app</string>
<string name="rt_ideas">Idee per nuove funzionalità</string>
<string name="rt_message_infrastructure_problem">Linea mancante, panchina rotta, ecc.</string>
<string name="rt_message_customer_service">Complimenti e lamentele sugli autisti, oggetti smarriti, ecc.</string>
<string name="rt_message_stop_problem">Linea mancante, fermata con nome errato, ecc.</string>
<string name="rt_message_arrival_problem">Mezzo mai arrivato, orario di arrivo sbagliato, ecc.</string>
<string name="rt_message_app_feedback">Design, bug, ecc.</string>
<string name="rt_message_ideas">Invia e vota per i miglioramenti futuri</string>
<string name="rt_address_hint">Indirizzo del problema (facoltativo)</string>
<string name="rt_yes">SÌ</string>
<string name="rt_no">NO</string>
Expand Down
6 changes: 0 additions & 6 deletions onebusaway-android/src/main/res/values-pl/arrays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -143,46 +143,40 @@
<item>@string/rt_infrastructure_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>
<string-array name="report_types_desc">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_infrastructure_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_types_without_open311">
<item>@string/rt_customer_service</item>
<item>@string/rt_stop_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>

<string-array name="report_types_desc_without_open311">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_stop_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons_without_open311">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_stop_issue_tutorial_desc">
Expand Down
6 changes: 0 additions & 6 deletions onebusaway-android/src/main/res/values/arrays.xml
Original file line number Diff line number Diff line change
Expand Up @@ -153,46 +153,40 @@
<item>@string/rt_infrastructure_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>
<string-array name="report_types_desc">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_infrastructure_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_types_without_open311">
<item>@string/rt_customer_service</item>
<item>@string/rt_stop_problem</item>
<item>@string/rt_arrival_problem</item>
<item>@string/rt_app_feedback</item>
<item>@string/rt_ideas</item>
</string-array>

<string-array name="report_types_desc_without_open311">
<item>@string/rt_message_customer_service</item>
<item>@string/rt_message_stop_problem</item>
<item>@string/rt_message_arrival_problem</item>
<item>@string/rt_message_app_feedback</item>
<item>@string/rt_message_ideas</item>
</string-array>

<array name="report_types_icons_without_open311">
<item>@drawable/ic_customer_service</item>
<item>@drawable/ic_stop_flag_triangle</item>
<item>@drawable/ic_arrival_time</item>
<item>@drawable/ic_app_feedback</item>
<item>@drawable/ic_light_bulb</item>
</array>

<string-array name="report_stop_issue_tutorial_desc">
Expand Down
4 changes: 0 additions & 4 deletions onebusaway-android/src/main/res/values/donottranslate.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@
<!-- Donate URL -->
<string name="donate_url">https://onebusaway.org/donate/</string>

<!-- IdeaScale URL -->
<string name="ideascale_url">https://onebusaway.ideascale.com/a/ideas/top/campaign-filter/byids/campaigns/46167</string>

<!-- Powered by OBA URL -->
<string name="powered_by_oba_url">https://onebusaway.org</string>

Expand Down Expand Up @@ -175,7 +172,6 @@
<string name="analytics_label_customer_service_email">Send email</string>
<string name="analytics_label_customer_service_email_without_location">Send email without location</string>
<string name="analytics_label_customer_service_phone">Make phone call</string>
<string name="analytics_label_idea_scale">IdeaScale</string>
<string name="analytics_label_custom_url">Custom URL</string>
<string name="analytics_label_star_route">Starred route</string>
<string name="analytics_label_unstar_route">Unstarred route</string>
Expand Down
2 changes: 0 additions & 2 deletions onebusaway-android/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -785,13 +785,11 @@
<string name="rt_stop_problem_title">Stop Problem</string>
<string name="rt_arrival_problem_title">Arrival Time Problem</string>
<string name="rt_app_feedback">Send App Feedback</string>
<string name="rt_ideas">Ideas For New Features</string>
<string name="rt_message_infrastructure_problem">Missing route, broken bench, etc.</string>
<string name="rt_message_customer_service">Driver compliments and complaints, lost &amp; found, etc.</string>
<string name="rt_message_stop_problem">Missing route, wrong stop name, etc.</string>
<string name="rt_message_arrival_problem">Vehicle never came, wrong arrival time, etc.</string>
<string name="rt_message_app_feedback">Design, bugs, etc.</string>
<string name="rt_message_ideas">Submit and vote on future improvements</string>
<string name="rt_address_hint">Address of problem (optional)</string>
<string name="rt_yes">YES</string>
<string name="rt_no">NO</string>
Expand Down

0 comments on commit af5e1ae

Please sign in to comment.