Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup option label improvements #377

Closed
bbodenmiller opened this issue Nov 18, 2015 · 5 comments
Closed

Backup option label improvements #377

bbodenmiller opened this issue Nov 18, 2015 · 5 comments

Comments

@bbodenmiller
Copy link
Contributor

I'm seeing some odd things in relation to the backup feature:

  • I'm given the option to backup to an SD card but my device does not have or support an SD card
  • Clicking the disabled restore from SD card option results in a popup asking if I'm sure
  • few days later and the restore from SD card option is now not appearing grayed out
@barbeau
Copy link
Member

barbeau commented Nov 18, 2015

Writing to storage on Android has always been tricky as there's been different behaviors on different devices and Android versions. Some comments inline below.

I'm given the option to backup to an SD card but my device does not have or support an SD card

We should rename the "SD card" label of the preferences to "storage". As you say, not all phones have an SD card. Furthermore, on an LG G4, even though an SD card is available, it writes to internal storage instead.

Clicking the disabled restore from SD card option results in a popup asking if I'm sure

I can't reproduce this on an LG G4 - when Restore is disabled a tap doesn't do anything.

The restore option should be only be enabled if a) storage is available on the device, AND b) you've previously saved a backup and its available in device storage.

Can you please try deleting the file "/OBABackups/db.backup" in your storage , and try this again?

You'll need to exit and re-start the app for it to pick up the change.

few days later and the restore from SD card option is now not appearing grayed out

As mentioned above, the restore option should be enabled after you successfully perform a save.

@barbeau barbeau added this to the Public v2.0.x release milestone Nov 18, 2015
@barbeau barbeau changed the title Backup option bugs Backup option improvements Nov 18, 2015
@bbodenmiller
Copy link
Contributor Author

Do we support the Backup API? I believe there was also talk before of doing some sort of cloud sync so you could switch between services easily (e.g. Same settings on phone and tablet).

@barbeau
Copy link
Member

barbeau commented Nov 18, 2015

We don't currently support the Backup API. I believe Android 6.0+ should automatically support it, though, although I haven't had a chance to really look into it. Backup is different from Cloud sync, which is ticketed in #32. Backup is intended to only be restored to a device when you first log into it, but its not intended to do an ongoing sync of data across devices. Cloud sync is intended to sync data across devices on an ongoing basis, so, for example, your phone favorites would always match your tablet favorites.

@bbodenmiller
Copy link
Contributor Author

It looks like backup API works on many versions of Android where as the new Android 6.0+ backup feature only works if you're running 6.0+ and your apps targets SDK version Android 6.0 (API level 23) and higher.

@barbeau barbeau changed the title Backup option improvements Backup option label improvements Nov 18, 2015
@barbeau
Copy link
Member

barbeau commented Nov 18, 2015

Fixed backup labels in develop via 075f416.

@bbodenmiller I'm going to close this issue - if you can reproduce the tapping on disabled Restore preference giving you a message (vs. not doing anything, which should be the proper behavior), please open a new issue for that specific problem.

@barbeau barbeau closed this as completed Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants