Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Added directions to polylines when routing #1119

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Adithya-hv
Copy link
Contributor

@Adithya-hv Adithya-hv commented Feb 24, 2024

Gradle gms:play-services-maps

Upgraded gms:play-services-maps to 18.2.0 allows for arrows to be built into polylines which was previously not possible, this makes the directions of the routes easier to differentiate.

Questions/Suggestions Request

  1. Unsure of the texture used
  2. Occurrence of arrows

Issues Affected

Closes #910

Screenshots

Untitled design(1)

Android CI Build

Pull Request Requirements

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

@Adithya-hv Adithya-hv changed the title Enhancement: Added directions to polylines when routing #910 Enhancement: Added directions to polylines when routing Feb 24, 2024
@Adithya-hv Adithya-hv marked this pull request as ready for review February 24, 2024 19:54
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, this looks awesome!

@aaronbrethorst aaronbrethorst merged commit 61e43f2 into OneBusAway:main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support direction filters for map shown on route
3 participants