Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Stub out core module #197

Closed
wants to merge 5 commits into from
Closed

WIP - Stub out core module #197

wants to merge 5 commits into from

Conversation

pohh
Copy link

@pohh pohh commented Dec 4, 2014

This request is to stub out the core functionality required by an android module which would be shared between the various deployed apps.

At present this set is limited to the wear module (to be completed in another pull), and the app.

The workflow I was thinking was as core functionality is required by features in the wear app, they would be moved from the current onebusaway-android module into the core module to keep the core module as lightweight as possible.

@pohh
Copy link
Author

pohh commented Dec 4, 2014

@barbeau would like feedback on:

  • package structure
  • package name
  • module name

@barbeau
Copy link
Member

barbeau commented Dec 4, 2014

@pohh Thanks! I agree that as functionality is required it should be moved to the core module to avoid unnecessary complexity in the core.

For file system structure, how about:

  • /core (as proposed here)
  • /wear
  • /app (currently "onebusaway-android")

In the current version of Android Studio the default subdirectory for Android apps is "/app" - early beta versions mirrored the "onebusaway-android" project name (IIRC when importing from Eclipse). So, I'm fine with renaming the main app directory if that aids in simplifying the organization/naming conversions. Git should allow retaining history over file moves (although Github history viewer currently does not).

I'll comment inline for the other items.

buildToolsVersion "21.1.1"

defaultConfig {
applicationId "org.onebusaway.android.core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@barbeau barbeau changed the title stub out core module WIP - Stub out core module Feb 25, 2015
@barbeau barbeau closed this Nov 23, 2015
@barbeau
Copy link
Member

barbeau commented Nov 23, 2015

This PR was automatically closed by Github due to the deletion of the develop branch - we're moving back to using master as the main branch.

@pohh Is this still something you're interested in working on? Just trying to get a handle of how this PR might look going forward - whether I need to pull into a branch to preserve the initial work for someone else to look at, or whether you want to rebase on master and continue work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants