Fix #162 - Add showNegativeScheduledArrivals option to data-sources.xml

[cagryInside]

I have implemented showNegativeScheduledArrivals option in data-soruces.xml. Now we can set the property:

  <property name="showNegativeScheduledArrivals" value="false" />

It set default true if a user never sets showNegativeScheduledArrivals property.

cc @barbeau

[onebusawaybot]

Can one of the admins verify this patch?

[barbeau]

@cagryInside Does this hide all negative arrivals (schedule and real-time times), or just negative arrivals for scheduled times when real-time isn't available? For the PSTA situation (which I still need to open an issue with an explanation for), we want to show negative arrivals for real-time data, but not for schedule data. So, we should only hide negative arrivals when no real-time info is available.

[barbeau]

On a related note, we should also probably rename the property to showNegativeScheduledArrivals.

[cagryInside]

@barbeau Yes this improvement hides all negative arrivals.
I check the negative arrivals by looking at the numberOfStopsAway property. Now, I should also check predictedArrivalTime. For example:

      if(!isNegativeArrivalsEnabled(instance.getBlockTrip().getTrip().getId().getAgencyId())
          && bean.getNumberOfStopsAway() < 0 && bean.getPredictedArrivalTime() <= 0)

But I am not sure this is the best approach the check predictedArrivalTime. Can we discuss this sometime this week?

[barbeau]

Yes, let's discuss this week.

[barbeau]

Per our discussion, bean.getPredictedArrivalTime() <= 0 is a good indicator of whether or not real-time info exists, so that portion looks fine.

[barbeau]

We're doing some final tests to make sure that bean.getNumberOfStopsAway() < 0 is a good indicator of whether or not the arrival is scheduled to have occurred in the past. If so, then everything should be working correctly. If not, we'll need to come up with another implementation to check if the scheduled time (arrival or departure, depending on the stop_sequence) is in the past.

[barbeau]

The issue describing the problem this PR addresses is #162.

[barbeau]

This patch is currently deployed to http://app.staging.obahart.org/ for the agency PSTA:
http://app.staging.obahart.org/where/standard/stop.action?id=PSTA_4025

[barbeau]

@sheldonabrown I believe this should be ready for review. We've been testing it with PSTA and it seems to be working as intended.

[sheldonabrown]

Merged this into camsys/unified branch, with intent to later merge camsys/unified to onebusaway/master

[aaronbrethorst]

no action in 8 years. closing.