Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Google map configuration #68

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: support Google map configuration #68

merged 1 commit into from
Mar 27, 2024

Conversation

Altonhe
Copy link
Member

@Altonhe Altonhe commented Mar 25, 2024 •
edited
Loading

As #11 mentioned, this PR add Google map-related configuration. Support the following variables in
https://github.com/OneBusAway/onebusaway-application-modules/blob/0e1ff4d06a49a65220242028c54df378eeecfd66/onebusaway-enterprise-webapp/src/main/webapp/WEB-INF/content/index.jspx#L51-L57

You can set the following args in docker-compose oba-app build args.

GOOGLE_MAPS_API_KEY=<YOUR_KEY_HERE>
GOOGLE_MAPS_CHANNEL_ID=<YOUR_CHANNEL_ID_HERE>
GOOGLE_MAPS_CLIENT_ID=<YOUR_CLIENT_ID_HERE>

Before:
image

After:
image

@Altonhe Altonhe marked this pull request as ready for review March 25, 2024 21:07
aaronbrethorst
aaronbrethorst approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work 👍 🗺️

@aaronbrethorst aaronbrethorst merged commit 5ab2ca0 into OneBusAway:main Mar 27, 2024
3 checks passed
This was referenced Mar 27, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbrethorst aaronbrethorst aaronbrethorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Altonhe @aaronbrethorst