DST should be abolished #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is indeed a bug with computation of service dates in CalendarServiceDataFactoryImpl when a feed uses only calendar_dates.txt to define the service calendar. I've got a fix for this that I believe will handle things in a more consistent way. |
bdferris
added a commit
that referenced
this pull request
Mar 24, 2012
Conflicts: onebusaway-gtfs/src/main/java/org/onebusaway/gtfs/serialization/GtfsEntitySchemaFactory.java Provides fix for Issue #1 and the DST issues described within.
|
I believe my changes to CalendarServiceDataFactoryImpl should fix the issue of DST calendar dates not being properly computed. I'm going to close this pull request. |
sdjacobs
pushed a commit
to sdjacobs/onebusaway-gtfs-modules
that referenced
this pull request
Dec 13, 2017
Add fare types to support Puget Sound fare calculation
sheldonabrown
pushed a commit
that referenced
this pull request
Jan 6, 2020
Updating personal to match upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue that's breaking OTP on DST switchover dates.