Use protobuf-maven-plugin to compile extensions automatically #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indings:0.05; rebuild extensions. This also necessitates bringing in the latest protobuf runtime explicitly, as the current version of protoc (and the runtime) is newer than what is used upstream.
|
Closing and re-opening, which should hopefully trigger Travis... |
|
@kurtraschke Sorry, I edited the README which caused conflicts with your changes. Would you mind resolving that (for some reason I can't via GitHub UI)? |
|
I'm quite interested in this change and wonder if it's possible to merge in. In particular, I'd like to add the following change to the library and this PR would simplify adding it: google/transit@5ce5f04 |
|
Sorry all, I'm still working with some projects using protoc 2.5 and protoc 2.6, so I've been hesitant to merge this. Perhaps I simply should branch for those to keep the project alive. Let me add another reminder... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (which is built on top of #16) adds
protobuf-maven-pluginto automatically invokeprotocas part of the build process (using a build ofprotocwhich is packaged as a Maven artifact so it is not required to be installed locally).In the future it would be nice to find some good way to get the canonical
gtfs-realtime.protointo this repository automatically (or, perhaps, include it as a Maven dependency).The brute-force solution to this would be to fetch
https://raw.githubusercontent.com/google/transit/master/gtfs-realtime/proto/gtfs-realtime.protoas part of the build process (for example, with the Maven AntRun plugin), but it doesn't really matter much anyway, as the only updates togtfs-realtime.protothat would matter in this context would be entirely new entities (and even then only if we wanted to extend them).