Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat 0 arrival/departure timestamps as equivalent to nothing #681

Closed
aaronbrethorst opened this issue Oct 6, 2023 · 0 comments · Fixed by #683
Closed

Treat 0 arrival/departure timestamps as equivalent to nothing #681

aaronbrethorst opened this issue Oct 6, 2023 · 0 comments · Fixed by #683
Assignees
@aaronbrethorst
Labels
Good First Issue

Comments

@aaronbrethorst
Copy link
Member

otherwise, we end up showing a ridiculous estimate for when a vehicle departed.

image0
aaronbrethorst added a commit that referenced this issue Oct 19, 2023
@aaronbrethorst
Attempts to fix wildly incorrect arrival-departure predictions
2a3fbd6 
Fixes #681

Before, we were `nil`'ing out ArrivalDeparture prediction dates whose values were `0`. Now, instead, we'll just treat anything earlier than 2001 as being invalid.

Note: 2001 is an arbitrary early cutoff. It could just as easily be `today - 1 month`.
@aaronbrethorst aaronbrethorst self-assigned this Oct 19, 2023
@aaronbrethorst aaronbrethorst mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronbrethorst aaronbrethorst

Labels
Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempts to fix wildly incorrect arrival-departure predictions OneBusAway/onebusaway-ios
1 participant
@aaronbrethorst