Change to AcquireToken to have refresh tokens cached properly #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 2, 2016 16:10
Fixes #36 When using the AquireTokenByRefreshToken(...) method, the underlying ADAL system does not guarentee the token will be saved for future use in the TokenCacheStore. Tracing into the AuthenticationContext implementation, refreshToken(..., final boolean useCache) is getting set to false in all of the 'refresh token` scenarios. Using aquireToken and then depending on the Prompt settings seems to be the best course of action to mitigate this issue. Note: it is not clear why this behavoir changed.
Noticed that we were missing some information from the logs when looking at traces, adding those details to speed up turn around time.
peternied
pushed a commit
that referenced
this pull request
Feb 3, 2016
Change to AcquireToken to have refresh tokens cached properly
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.