Remove support for form buttons - it doesn't make sense for now

onegov/form/parser/core.py

@@ -25,9 +25,6 @@ class (not an instance of it).
         if block.type == 'fieldset':
             builder.set_current_fieldset(block.label or None)
 
-        elif block.type == 'button':
-            raise NotImplementedError
-
         elif block.type == 'text':
             if block.length:
                 validators = [Length(max=block.length)]

onegov/form/parser/grammar.py

@@ -55,20 +55,6 @@
     # ...
     I don't belong to a Fieldset = ___
 
-Buttons
--------
-
-Buttons come in two versions. One without address, and one with. If there's no
-address, the button POSTs to the current url. If there is an url, the button
-POSTs the form the the given url.
-
-For example::
-
-        [Submit to current URL]
-        [Submit to another URL](http://my-post-address.com)
-
-You'll notice that this looks just like a Markdown link.
-
 Available Fields
 ----------------
 
@@ -414,32 +400,6 @@ def custom():
     return custom
 
 
-def button():
-    """ Returns a buttons parser.
-
-    Examples::
-
-        [Send]
-        [Send](http://my-post-address.com)
-
-    By default, buttons post to the form.
-
-    """
-
-    characters = with_whitespace_inside(text_without('[]'))
-
-    label = Combine(OneOrMore(characters))('label')
-    label.setParseAction(lambda t: t[0])
-
-    url = OneOrMore(text_without('()'))('url').setParseAction(lambda t: t[0])
-
-    button = Suppress('[') + label + Suppress(']')
-    button += Optional(Suppress('(') + url + Suppress(')'))
-    button.setParseAction((tag(type='button')))
-
-    return button
-
-
 def fieldset_title():
     """ A fieldset title parser. Fieldset titles are just like headings in
     markdown::
@@ -492,7 +452,6 @@ def block_content():
     identifier = field_identifier()
 
     return MatchFirst([
-        button(),
         fieldset_title(),
         identifier + (textfield() | textarea() | password() | custom()),
         identifier + OneOrMore(Optional(LE) + radios())('parts'),

onegov/form/tests/test_grammar.py

@@ -2,7 +2,6 @@
 import textwrap
 
 from onegov.form.parser.grammar import (
-    button,
     custom,
     document,
     field_identifier,
@@ -137,24 +136,6 @@ def test_custom():
     assert f.asDict() == {'type': 'custom', 'custom_id': 'stripe'}
 
 
-def test_button():
-
-    btn = button()
-
-    f = btn.parseString("[Click Me!](https://www.google.ch)")
-    assert f.asDict() == {
-        'type': 'button',
-        'label': 'Click Me!',
-        'url': 'https://www.google.ch'
-    }
-
-    f = btn.parseString("[Send]")
-    assert f.asDict() == {
-        'type': 'button',
-        'label': 'Send'
-    }
-
-
 def test_document():
     # a form that includes all the features available
     form = textwrap.dedent("""
@@ -175,12 +156,10 @@ def test_document():
         Password = ***
         Comment = ...
         E-Mail = /E-Mail
-
-        [Submit](https://www.google.ch)
     """)
 
     result = document().searchString(form)
-    assert len(result) == 11
+    assert len(result) == 10
 
     assert result[0].asDict() == {'label': 'Name', 'type': 'fieldset'}
 
@@ -236,11 +215,6 @@ def test_document():
         'type': 'custom',
         'custom_id': 'e-mail'
     }
-    assert result[10].asDict() == {
-        'label': 'Submit',
-        'type': 'button',
-        'url': 'https://www.google.ch'
-    }
 
 
 def test_multiline_checkboxes():