Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for private BTC external account connection #4488

Merged
merged 11 commits into from
May 28, 2024
Merged

feat: Add support for private BTC external account connection #4488

merged 11 commits into from
May 28, 2024

Conversation

originalix
Copy link
Contributor

No description provided.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Apr 23, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@originalix originalix enabled auto-merge (squash) April 23, 2024 09:26
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Apr 23, 2024

PR Summary

  • Updated Dependencies
    The code dependencies listed in package.json have been refreshed. This includes changes to the versions of various packages like @onekeyfe/cross-inpage-provider-*, @onekeyfe/hd-*, and @tamagui/*. Furthermore, a new dependency, @onekeyfe/hd-ble-sdk, has been included to enrich the project's functionality.

  • New File Addition
    A new file ProviderApiPrivateExternalAccount.ts has been added in the kit-bg/src/providers/ location, introducing new chunks of code to assist the application's functionality.

  • Extended Provider Implementation
    The provider implementation representation in backgroundProviders.ts now offers ProviderApiPrivateExternalAccount. This means the program has a new way of providing specific resources to be utilized more effectively.

  • Alterations to Vault.ts
    The buildUnsignedTx method in Vault.ts now acknowledges an optional parameter called encodedTx. This substantially nourishes the method's flexibility for dealing with different data inputs.

  • Support for $privateExternalAccount Scope
    The program now supports the $privateExternalAccount scope, indicated in the backgroundUtils.ts. This enhancement makes it possible to access and manipulate more data at a wider level than before within the program's structure.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 23, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@huhuanming
Copy link
Contributor

@SocketSecurity ignore npm/protobufjs@6.11.4
@SocketSecurity ignore npm/esbuild@0.19.12

huhuanming
huhuanming previously approved these changes Apr 25, 2024
View reviewed changes
weatherstar
weatherstar previously approved these changes Apr 26, 2024
View reviewed changes
kwoktung
kwoktung previously approved these changes Apr 26, 2024
View reviewed changes
@originalix originalix marked this pull request as draft April 30, 2024 02:21
auto-merge was automatically disabled April 30, 2024 02:21

Pull request was converted to draft

@originalix
Merge branch 'x' of github.com:OneKeyHQ/app-monorepo into feat/btc-ex…
8f197c9 
…ternalAccount

# Conflicts:
#	package.json
#	packages/kit-bg/src/providers/backgroundProviders.ts
#	packages/kit-bg/src/vaults/impls/btc/Vault.ts
#	yarn.lock
@originalix originalix dismissed stale reviews from kwoktung, weatherstar, and huhuanming via 8f197c9 May 24, 2024 08:00
@socket-security Socket Security
Copy link

socket-security bot commented May 26, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@onekeyfe/cross-inpage-provider-core@2.0.0-alpha.7 environment 0 186 kB 1keyfe
npm/@onekeyfe/cross-inpage-provider-errors@2.0.0-alpha.7 None 0 42.2 kB 1keyfe
npm/@onekeyfe/cross-inpage-provider-events@2.0.0-alpha.7 None 0 17.8 kB 1keyfe
npm/@onekeyfe/cross-inpage-provider-injected@2.0.0-alpha.7 None 0 5.96 MB 1keyfe
npm/@onekeyfe/cross-inpage-provider-types@2.0.0-alpha.7 None 0 10.5 kB 1keyfe
npm/@onekeyfe/desktop-bridge-injected@2.0.0-alpha.7 None 0 7.39 kB 1keyfe
npm/@onekeyfe/extension-bridge-hosted@2.0.0-alpha.7 None 0 47.7 kB 1keyfe
npm/@onekeyfe/extension-bridge-injected@2.0.0-alpha.7 None 0 9.97 kB 1keyfe
npm/@onekeyfe/inpage-providers-hub@2.0.0-alpha.7 environment 0 622 kB 1keyfe
npm/@onekeyfe/native-bridge-injected@2.0.0-alpha.7 None 0 5.36 kB 1keyfe
npm/@onekeyfe/onekey-aptos-provider@2.0.0-alpha.7 None 0 49.7 kB 1keyfe
npm/@onekeyfe/onekey-btc-provider@2.0.0-alpha.7 None 0 45.9 kB 1keyfe
npm/@onekeyfe/onekey-cardano-provider@2.0.0-alpha.7 None 0 37.5 kB 1keyfe
npm/@onekeyfe/onekey-conflux-provider@2.0.0-alpha.7 None 0 32.3 kB 1keyfe
npm/@onekeyfe/onekey-cosmos-provider@2.0.0-alpha.7 None 0 47.7 kB 1keyfe
npm/@onekeyfe/onekey-cross-webview@2.0.0-alpha.7 environment 0 55.6 kB 1keyfe
npm/@onekeyfe/onekey-eth-provider@2.0.0-alpha.7 None 0 103 kB 1keyfe
npm/@onekeyfe/onekey-nostr-provider@2.0.0-alpha.7 None 0 19.9 kB 1keyfe
npm/@onekeyfe/onekey-polkadot-provider@2.0.0-alpha.7 None +2 191 kB 1keyfe
npm/@onekeyfe/onekey-private-external-account-provider@2.0.0-alpha.7 None 0 16.9 kB 1keyfe
npm/@onekeyfe/onekey-private-provider@2.0.0-alpha.7 None 0 10.9 kB 1keyfe
npm/@onekeyfe/onekey-solana-provider@2.0.0-alpha.7 None 0 84.8 kB 1keyfe
npm/@onekeyfe/onekey-starcoin-provider@2.0.0-alpha.7 None 0 93.6 kB 1keyfe
npm/@onekeyfe/onekey-sui-provider@2.0.0-alpha.7 None 0 41.8 kB 1keyfe
npm/@onekeyfe/onekey-tron-provider@2.0.0-alpha.7 None 0 36.2 kB 1keyfe
npm/@onekeyfe/onekey-webln-provider@2.0.0-alpha.7 None 0 27.1 kB 1keyfe
npm/error-stack-parser@2.1.4 None 0 35.9 kB titanism
npm/html-entities@2.5.2 None 0 287 kB mdevils

🚮 Removed packages: npm/@onekeyfe/cross-inpage-provider-core@2.0.0-alpha.5, npm/@onekeyfe/cross-inpage-provider-errors@2.0.0-alpha.5, npm/@onekeyfe/cross-inpage-provider-events@2.0.0-alpha.5, npm/@onekeyfe/cross-inpage-provider-injected@2.0.0-alpha.5, npm/@onekeyfe/cross-inpage-provider-types@2.0.0-alpha.5, npm/@onekeyfe/desktop-bridge-injected@2.0.0-alpha.5, npm/@onekeyfe/extension-bridge-hosted@2.0.0-alpha.5, npm/@onekeyfe/extension-bridge-injected@2.0.0-alpha.5, npm/@onekeyfe/inpage-providers-hub@2.0.0-alpha.5, npm/@onekeyfe/native-bridge-injected@2.0.0-alpha.5, npm/@onekeyfe/onekey-aptos-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-btc-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-cardano-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-conflux-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-cosmos-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-cross-webview@2.0.0-alpha.5, npm/@onekeyfe/onekey-eth-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-nostr-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-polkadot-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-private-external-account-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-private-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-solana-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-starcoin-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-sui-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-tron-provider@2.0.0-alpha.5, npm/@onekeyfe/onekey-webln-provider@2.0.0-alpha.5, npm/fast-json-stable-stringify@2.1.0, npm/mimic-fn@2.1.0

View full report↗︎

@originalix originalix marked this pull request as ready for review May 26, 2024 04:09
@originalix originalix enabled auto-merge (squash) May 26, 2024 13:51
weatherstar
weatherstar previously approved these changes May 27, 2024
View reviewed changes
@originalix
Merge branch 'x' of github.com:OneKeyHQ/app-monorepo into feat/btc-ex…
86a33b7 
…ternalAccount

# Conflicts:
#	packages/core/src/chains/btc/sdkBtc/index.ts
@originalix originalix merged commit b567a1a into x May 28, 2024
4 checks passed
@originalix originalix deleted the feat/btc-externalAccount branch May 28, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidmorizon sidmorizon sidmorizon approved these changes

@huhuanming huhuanming huhuanming approved these changes

@weatherstar weatherstar weatherstar left review comments

@kwoktung kwoktung kwoktung left review comments

@ezailWang ezailWang Awaiting requested review from ezailWang ezailWang is a code owner

@loatheb loatheb Awaiting requested review from loatheb loatheb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@originalix @huhuanming @weatherstar @sidmorizon @kwoktung