Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update startGetLocation to only run if location is shared #1942

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Fix: Update startGetLocation to only run if location is shared #1942

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c0b8592
Update startGetLocation to only run if location is shared
jennantilla Dec 13, 2023
7bc4aa3
Fix linting error
jennantilla Dec 13, 2023
ec79584
Update startGetLocation to return early if isShared is false
jennantilla Dec 13, 2023
f275b24
Update isShared default to false
jennantilla Dec 20, 2023
a7d7a72
Allow for mid-session update of location permission
jennantilla Dec 20, 2023
fc842b9
Remove early return for requestPermission
jennantilla Dec 26, 2023
8b0b74b
Update LocationManager
jennantilla Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ...alSDK/onesignal/location/src/main/java/com/onesignal/location/internal/LocationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,18 @@ internal class LocationManager(

// Started from this class or PermissionActivity
private suspend fun startGetLocation() {
Logging.debug("LocationManager.startGetLocation()") // with lastLocation: " + lastLocation)
try {
if (!_locationController.start()) {
Logging.warn("LocationManager.startGetLocation: not possible, no location dependency found")
if (isShared) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend returning early instead if isShared is false, this keeps the code from getting to nested.

Logging.debug("LocationManager.startGetLocation()") // with lastLocation: " + lastLocation)
try {
if (!_locationController.start()) {
Logging.warn("LocationManager.startGetLocation: not possible, no location dependency found")
}
} catch (t: Throwable) {
Logging.warn(
"LocationManager.startGetLocation: Location permission exists but there was an error initializing: ",
t,
)
}
} catch (t: Throwable) {
Logging.warn("LocationManager.startGetLocation: Location permission exists but there was an error initializing: ", t)
}
}
}
Loading