Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Cancelling permission request dialog does not fire continuation #2085

Merged
merged 1 commit into from
May 10, 2024

Conversation

jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented May 10, 2024

Description

One Line Summary

Add a OnCancelListener to permission prompt so that dismissing (clicking outside of the dialog box) is treated as denying permission.

Details

Motivation

We want to correctly update the permission grant status to false when the user dismisses the permission request prompt without either rejecting or accepting it.

Scope

Clicking outside of permission request box will now treated as denying the permission. This will works for both notification permission and location permission.

Testing

Manual testing

Step to reproduce:

  1. Turn off notification permission in app setting
  2. Open the app and prompt for notification permission
  3. Click outside to dismiss the alert dialog asking to allow OneSignal to send notification
  4. Click outside to dismiss next dialog directing to app settings
  5. Notice that the break point at onDecline is reached; this is not the case before the fix.
    image

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jinliu9508 jinliu9508 changed the title Fix: Cancelling permission request dialog does not fire continuation [Fix]: Cancelling permission request dialog does not fire continuation May 10, 2024
@jinliu9508 jinliu9508 merged commit a6e9f80 into main May 10, 2024
2 checks passed
@jinliu9508 jinliu9508 deleted the request-permission-dismiss-continuation branch May 10, 2024 20:40
@jinliu9508 jinliu9508 mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants