Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Bump native OneSignal SDKs versions #722

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Apr 16, 2024

Description

One Line Summary

Updates included OneSignal Android SDK from 5.1.7 to 5.1.8 and OneSignal iOS SDK from 5.1.4 to 5.1.5

Details

Motivation

Apply fixes made in the native SDKs to the Unity wrapper SDK.

Scope

Updated included Android SDK from 5.1.8 to 5.1.9

  • Added AndroidManifest option to override In-App Messages gray overlay and dropshadow
    • <meta-data android:name="com.onesignal.inAppMessageHideGrayOverlay" android:value="true"/>
    • <meta-data android:name="com.onesignal.inAppMessageHideDropShadow" android:value="true"/>
  • Fixed WorkManager not initialized crash
  • Fixed don't re-create user on failed remove alias
  • Added network call optimizations
  • For full changes, see the native release notes

Updated included iOS SDK from 5.1.4 to 5.1.5

  • Added plist option to hide gray overlay and disable dropshadow for In-App Messages
    • OneSignal_in_app_message_hide_gray_overlay
    • OneSignal_in_app_message_hide_drop_shadow
  • For full changes, see the native release notes

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2021.3.10f1 of the OneSignal example App on an iPhone 12 with iOS 15.5.
Added OneSignal_in_app_message_hide_drop_shadow to the plist and set Type Boolean to YES and In-App Message did not display drop shadow.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l changed the title [Feat] Bump native OneSignal SDK versions [Feat] Bump native OneSignal SDKs versions Apr 16, 2024
@shepherd-l shepherd-l merged commit 1a1dbdf into main Apr 16, 2024
1 check passed
@shepherd-l shepherd-l deleted the feat/updateNativeOneSignalSDKs branch April 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants