[User Model] [Fix] Notification permission change event stop firing

[jkasten2]

Description

1 Line Summary

Fix bug where notification permission change would stop firing due to a bad state.

Details

There was an early return on shouldBeUpdated that caused executing to never become false again. To prevent this issue with future code changes made a new privateTriggerNotificationPermissionChanged to encapsulate the executing state. Also added a try..finally to prevent throwing from creating a bad state.

Validation

Tests

Tested on Chrome on macOS. Toggle notifications on and off and observed bell icon and custom link change, where it was broken before.

Info

Checklist

• All the automated tests pass or I explained why that is not possible
• I have personally tested this on my machine or explained why that is not possible
• I have included test coverage for these changes or explained why they are not needed

Programming Checklist
Interfaces:

• Don't use default export
• New interfaces are in model files

Functions:

• Don't use default export
• All function signatures have return types
• Helpers should not access any data but rather be given the data to operate on.

Typescript:

• No Typescript warnings
• Avoid silencing null/undefined warnings with the exclamation point

Other:

• Iteration: refrain from using elem of array syntax. Prefer forEach or use map
• Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Info

Checklist

• I have included screenshots/recordings of the intended results or explained why they are not needed

---

Related Tickets

Bug was introduced in PR #1050
This PR mirrors the same fix from main's #1071 PR.

---

---

This change is