Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Model] [Fix] Notification permission change event stop firing #1072

Merged
merged 1 commit into from
Aug 2, 2023
Merged

[User Model] [Fix] Notification permission change event stop firing #1072

merged 1 commit into from
Aug 2, 2023

Commits on Aug 1, 2023

  1. fix executing state on PermissionUtils 

    There was an early return on shouldBeUpdated that caused executing to
never become false again. To prevent this issue with future code
changes made a new privateTriggerNotificationPermissionChanged to
encapsulate the executing state. Also added a try..finally to prevent
throwing from creating a bad state.
    @jkasten2
    jkasten2 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    40e2454 View commit details
    Browse the repository at this point in the history