userConfig service worker param fix
#858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgomezp
force-pushed
the
serviceWorkerParam-fix
branch
5 times, most recently
from
4483e84
to
9ac32f8
Compare
- This change should work because this point in the codepath should guarantee that the `OneSignal` object is defined (config helper is called after initialization) - We give preference to the `userConfig` version of the param over the top-level parameter since the top-level is assigned a default value when it is initialized. The `userConfig` version would only exist if explicitly passed in
rgomezp
force-pushed
the
serviceWorkerParam-fix
branch
from
9ac32f8
to
8c64c31
Compare
jkasten2
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rgomezp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the
userConfigversions of the Service Worker config parameters which were previously unused. This is crucial to easily support non-root scope integrations when using the web-shim distributions.See commits for details.
This change is