Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userConfig service worker param fix #858

Merged
merged 2 commits into from Sep 20, 2021
Merged

userConfig service worker param fix #858

merged 2 commits into from Sep 20, 2021

Commits on Sep 20, 2021

  1. Fix issue where userConfig SW params aren't used 

    - This change should work because this point in the codepath should guarantee that the `OneSignal` object is defined (config helper is called after initialization)
- We give preference to the `userConfig` version of the param over the
top-level parameter since the top-level is assigned a default value when
it is initialized. The `userConfig` version would only exist if
explicitly passed in
    @rgomezp
    rgomezp committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    554ad88 View commit details
    Browse the repository at this point in the history

  2. 151508 Release Commit

    @rgomezp
    rgomezp committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8c64c31 View commit details
    Browse the repository at this point in the history