Location sharing with OneSignal now defaults to false

[nan-li]

Description

One Line Summary

Location sharing with OneSignal now defaults to false regardless of device permissions, so developers must explicitly set sharing to true.

Details

Motivation

It may be a poor developer experience to be opted-in by default. Previously, as long as device has location permission, we shared location with the OneSignal server. Now, sharing must be explicitly enabled. This aligns with recent similar Android behavior changes OneSignal/OneSignal-Android-SDK#1942.

Scope

⚠️ Behavior changes:

• Developers must now explicitly call OneSignal.Location.isShared = true (Swift) or [OneSignal.Location setShared:true] to share location with OneSignal regardless of permission or prompting for location.

Fix location module bug

• Use constants for Location and IAM module classes that are used with NSClassFromString: OneSignalLocationManager and OneSignalInAppMessages
• These hardcoded classes can be easily missed. When the class OneSignalLocation was renamed to OneSignalLocationManager, some of the strings were missed in NSClassFromString calls. One consequence of this is the location module's start method never ran and location not shared.

Testing

Unit testing

None

Manual testing

iPhone 13 on iOS 17.1.2

• Enable and then request permission → shares location when both steps are done
• Request permission and then enable → shares location when both steps are done

Something that is not working is mid-session disabling and enabling doesn't drive location sharing until next cold start.

1. Already sharing location
2. Disable sharing - location stops being tracked and shared
3. Enable sharing - location sharing doesn't start
4. New cold start - location is shared

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes
• Location sharing

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
• I have reviewed this PR myself, ensuring it meets each checklist item

---

This change is 

[emawby]

Should we update the migration guide to call out the new default as well?

[nan-li]

Should we update the migration guide to call out the new default as well?

Done. We will also need to update our docs calling this out for v5.1.0 and above.

[jennantilla]

Looks great! Confirmed that isShared now defaults to false.