Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Location sharing with OneSignal now defaults to false #1352

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Location sharing with OneSignal now defaults to false #1352

merged 3 commits into from
Jan 5, 2024

Commits on Jan 3, 2024

  1. location sharing with OneSignal now defaults to NO 

    * Location sharing with OneSignal will default to NO, regardless of prompting or location permission on the device
    @nan-li
    nan-li committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    05a981d View commit details
    Browse the repository at this point in the history

  2. Use constants for Location and IAM module classes 

    Details:
* Use constants for the 2 class names for the Location and IAM modules that are used by NSClassFromString: `OneSignalLocationManager` and `OneSignalInAppMessages`
Motivation:
* These can be easily missed. When the class `OneSignalLocation` was renamed to `OneSignalLocationManager`, some of the hardcoded strings were missed in `NSClassFromString` calls.
    @nan-li
    nan-li committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    68f9b7f View commit details
    Browse the repository at this point in the history

  3. Migration guide - location sharing must be enabled

    @nan-li
    nan-li committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ad5e7f2 View commit details
    Browse the repository at this point in the history