Fix Semaphore Timeout #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• When getting the current notification state in iOS 10 +, our SDK was using a semaphore to do this synchronously. • However, the SDK was waiting on the semaphore with unlimited timeout, so there was the potential to block the thread indefinitely. • Adds a 100 millisecond timeout to ensure this call never results in a blocked thread
jkasten2
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Nightsd01
added a commit
that referenced
this pull request
Sep 10, 2018
• Fixes an issue (#410) where users that add buttons/functionality to a notification by directly using UNNotificationCategory instead of using our API would cause a crash • Fixes a thread synchronization issue that would have deadlocked the main thread in very rare situations on initialization (#409) • Fixes an issue where improperly formatted button JSON would cause the SDK to insert nil objects into an NSDictionary instance, causing an EXC_BAD_ACCESS (#409) • Adds an additional dynamic framework/cocoapod for developers who previously encountered 'transitive dependency' errors using our SDK indirectly as a dependency of another cocoapod in Swidft projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• When getting the current notification state in iOS 10 +, our SDK was using a semaphore to do this synchronously.
• However, the SDK was waiting on the semaphore with unlimited timeout, so there was the potential to block the thread indefinitely.
• Adds a 100 millisecond timeout to ensure this call never results in a blocked thread
• Fixes #407
This change is