Add arm64 slice to XCFramework simulator build #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support Apple Silicon macs we need to add arm64 to iOS simulator builds. This only works with XCFrameworks since we also need arm64 for iOS devices.
jkasten2
approved these changes
Dec 17, 2020
Jeasmine
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support Apple Silicon macs we need to add arm64 to iOS simulator builds. This only works with XCFrameworks since we also need arm64 for iOS devices. For now the OneSignal framework will stay with iOS simulators built for x86_64 so folks now using apple silicon that were previously using the framework now will need to use the XCFramework. This should not impact non apple silicon users at all
This change is