-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extinct species without extinction dates #126
Comments
My inclination is to use -1e4 and check for branch lengths < -5e3. It used to be the case that I used negative branch lengths to indicate uncertain taxon placement (see tree in |
It looks like these are simply ignored, and the length set to 0 (indicating a polytomy) -
|
Started coding on the Extinct-taxa branch |
At the moment, we identify extinct species by the fact that their entry in the ordered_leaves table has a positive floating point number (in millions of years) in the extinction_date column (there are only 3 such leaves at the moment). Species that are not extinct have NULL in that column.
The new version of the OpenTree will include extinct taxa, but will not contain their extinction dates. We need a way to mark taxa as extinct but with no date. We could possibly do this by using a placeholder value (annoyingly, mySQL doesn't allow NaN, +inf, or -inf, so a suggested placeholder would either be a number larger than 5000 (as they cannot be older than 5000 million years ago, the age of the earth), or possibly a negative number (e.g. -1e4)
The text was updated successfully, but these errors were encountered: