Refactor SbpXXX to cfg::SbpXXX #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poohRui
reviewed
Jun 7, 2021
oneflow/core/framework/infer_parallel_distribution_fn_context.h
Outdated
Show resolved
Hide resolved
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
4adb815
to
9dbedec
Compare
poohRui
approved these changes
Jun 7, 2021
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
f1b1662
to
fd1c54f
Compare
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
a248d94
to
fd1c54f
Compare
poohRui
reviewed
Jun 8, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
8366242
to
4bc1271
Compare
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
…Inc/oneflow into refactor_sbp_to_cfg_sbp
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
48a20fc
to
77e962c
Compare
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
77e962c
to
472f765
Compare
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
liufengwei0103
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
a7b6e7b
to
40638ae
Compare
poohRui
force-pushed
the
refactor_sbp_to_cfg_sbp
branch
from
40638ae
to
143ea7a
Compare
…low into refactor_sbp_to_cfg_sbp Conflicts: docker/package/manylinux/build_wheel.py
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
liujuncheng
reviewed
Jun 23, 2021
| std::function<Maybe<const SbpInferHint*>(const std::string&)> SbpInferHint4Ibn, | ||
| const ParallelDesc& parallel_desc) const override { | ||
| CHECK_NE_OR_RETURN(op_conf().cast_to_mirrored_conf().sbp_parallel().parallel_type_case(), | ||
| SbpParallel::PARALLEL_TYPE_NOT_SET) | ||
| cfg::SbpParallel::PARALLEL_TYPE_NOT_SET) |
There was a problem hiding this comment.
这里改动完成后 CHECK 的两个参数不一样，一个是 proto 的 enum，一个是 cfg 的 enum，编译器会有警告
daquexian
reviewed
Oct 28, 2021
| parallel_distribution_signature_( | ||
| &(kernel_conf.op_attribute().parallel_distribution_signature())) { | ||
| parallel_desc_(kernel_conf.op_attribute().parallel_conf_signature().op_parallel_conf()) { | ||
| parallel_distribution_signature_ = new cfg::ParallelDistributionSignature( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor SbpXXX to cfg::SbpXXX