Add cmake option CUDA_STATIC #5164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake/third_party.cmake
Outdated
| find_cuda_helper_libs(nvjpeg) | ||
| list(APPEND OF_CUDA_LIBRARIES ${CUDA_nvjpeg_LIBRARY}) | ||
| list(APPEND OF_CUDA_LIBRARIES ${CUDA_nppc_LIBRARY}) | ||
| list(APPEND OF_CUDA_LIBRARIES ${CUDA_nppig_LIBRARY}) |
There was a problem hiding this comment.
oneflow.cmake 里面现在已经有个 ONEFLOW_CUDA_LIBS 了，为了避免混淆，这个OF_CUDA_LIBRARIES是不是可以考虑改个名字，比如 VENDOR_CUDA_LIBRARIES
| if (BUILD_CUDA) | ||
| if ((NOT CUDA_STATIC) OR WITH_XLA OR BUILD_SHARED_LIBS) |
There was a problem hiding this comment.
建议拿一个干净的build目录，测试一下 BUILD_SHARED_LIBS=ON 的时候能不能正常编译运行
jackalcooper
approved these changes
Jun 10, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.