[Functional] Part2: Add partial unary and math functional apis #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjchen2
requested review from
Flowingsun007,
doombeaker,
BBuf,
VertexC and
Ldpe2G
and removed request for
Flowingsun007 and
doombeaker
BBuf
approved these changes
Jun 18, 2021
hjchen2
commented
Jun 18, 2021
| } | ||
| } | ||
| Maybe<Tensor> operator()(const TensorTuple& inputs) const { | ||
| CHECK_GE_OR_RETURN(inputs.size(), 2); |
There was a problem hiding this comment.
add都是两个或两个以上的tensor相加，length 0或1都是不合法的输入
wyg1997
reviewed
Jun 18, 2021
VertexC
reviewed
Jun 18, 2021
Co-authored-by: Yinggang Wang <wyg19970408@gmail.com>
…com/Oneflow-Inc/oneflow into dev_functional_unary_and_binary_ops
wyg1997
approved these changes
Jun 18, 2021
VertexC
approved these changes
Jun 18, 2021
hjchen2
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.