Release lambda function to reuse tensor memory #5266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyg1997
commented
Jun 22, 2021
| @@ -110,7 +110,6 @@ void StackFunctionNode::ReleaseOutTensorArgs() { | |||
| void StackFunctionNode::ReleaseData() { | |||
| // Releases backward function and makes useless tensors release as early as possible | |||
| if (!input_meta_datas_.empty()) { backward_fn_.reset(); } | |||
| next_functions_->clear(); | |||
There was a problem hiding this comment.
这里不能清理，避免 lambda 中没有捕获input tensor导致FunctionNode提前释放。
hjchen2
approved these changes
Jun 22, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FunctionNode计算后立即释放掉lambda backward function，使lambda里捕获的tensor可以及时释放，节省显存。
在resnet50上测试，输入为 (32, 3, 224, 224) 时，显存优化情况为：
4400MB -> 4178MB