fix multithread bug in env #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengwei0103
force-pushed
the
fix_multithread_bug_in_env
branch
from
8cf244f
to
b3f51d7
Compare
lixinqi
reviewed
Jun 25, 2021
Comment on lines
181
to
183
| const auto& iter = device2parallel_desc_.find(device); | ||
| if (iter != device2parallel_desc_.end()) { return iter->second; } |
liufengwei0103
force-pushed
the
fix_multithread_bug_in_env
branch
from
b3f51d7
to
bbd8e2d
Compare
liufengwei0103
force-pushed
the
fix_multithread_bug_in_env
branch
from
bbd8e2d
to
41e3920
Compare
liufengwei0103
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
lixinqi
approved these changes
Jun 29, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.