Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev sort eager #5284

Merged
merged 9 commits into from
Jun 25, 2021
Merged

Dev sort eager #5284

merged 9 commits into from
Jun 25, 2021

Conversation

simonJJJ
Copy link
Contributor

image
image

@simonJJJ simonJJJ requested a review from BBuf June 23, 2021 09:31
BBuf
BBuf reviewed Jun 23, 2021
View reviewed changes
oneflow/python/nn/modules/sort.py
super().__init__()
self.dim = dim
direction = "DESCENDING" if descending else "ASCENDING"
self._argsort_op = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以把argsort用funciton的方式重写一下。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个要不再重新开个pr吧，之前的argsort也没用function

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在后江的functional的PR合并进master了，按道理新增的算子，应该都优先考虑functional。
不过世杰要这两个算子（sort、argsort）要的比较急，这个PR可以特殊一点。
要么世杰自己评估下，如果时间上不允许，就先按原来方式搬。

等这个PR合并进了，再和我说下，我找人改成 fucntional 吧（反正还有其它地方要改，可以一起做了）。

@BBuf @simonJJJ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，我觉得可以先合并，再来改

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同意

@simonJJJ simonJJJ requested a review from BBuf June 23, 2021 11:14
@doombeaker doombeaker mentioned this pull request Jun 24, 2021
Closed
@oneflow-ci-bot oneflow-ci-bot self-requested a review June 25, 2021 06:52
@oneflow-ci-bot oneflow-ci-bot merged commit 82f5131 into master Jun 25, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_sort_eager branch June 25, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doombeaker doombeaker doombeaker left review comments

@BBuf BBuf BBuf approved these changes

@oneflow-ci-bot oneflow-ci-bot Awaiting requested review from oneflow-ci-bot

Assignees
No one assigned
Labels
automerge eager enhancement op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simonJJJ @doombeaker @BBuf @oneflow-ci-bot