Infer consistent tensor meta #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…infer_consistent_tensor_meta Conflicts: oneflow/core/framework/op_expr.h oneflow/core/framework/tensor.h oneflow/core/framework/tensor_impl.h
…infer_consistent_tensor_meta Conflicts: oneflow/core/framework/tensor_impl.cpp
…flow-Inc/oneflow into infer_consistent_tensor_meta
…flow-Inc/oneflow into infer_consistent_tensor_meta
clackhan
commented
Jul 1, 2021
| return infer_args; | ||
| } | ||
|
|
||
| private: | ||
| ConsistentTensorMetaInferArgs() = default; | ||
| Maybe<void> Init(const TensorTuple& input_tensors, Symbol<PlacementScope> placement_scope, | ||
| const AttrMap& attrs); |
There was a problem hiding this comment.
这个Init是作为public方法还是和构造方法合并？我拿不准 @daquexian
There was a problem hiding this comment.
这个方法会返回 Maybe，所以不能和构造方法合并，就应该保持现在的样子吧
There was a problem hiding this comment.
这个方法是不是可以删掉，把它的内容写在 New 方法里面
clackhan
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
daquexian
approved these changes
Jul 1, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.