Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev ofrecord auto truncating #5412

Merged
merged 16 commits into from
Jul 15, 2021
Merged

Dev ofrecord auto truncating #5412

merged 16 commits into from
Jul 15, 2021

Conversation

ShawnXuan
Copy link
Contributor

replace auto_zero_padding with auto_truncating
when auto_truncating is True

  • If list.value_size is larger than sample_elem_cnt, the extra data is discarded.;
  • If list.value_size is shorter, it is extended with zero padding.

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 14, 2021 14:44
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 14, 2021 22:39
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 15, 2021 00:41
@oneflow-ci-bot oneflow-ci-bot merged commit 1112684 into master Jul 15, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_ofrecord_auto_truncating branch July 15, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaves-zwx leaves-zwx leaves-zwx approved these changes

@liujuncheng liujuncheng Awaiting requested review from liujuncheng

@doombeaker doombeaker Awaiting requested review from doombeaker

Assignees
No one assigned
Labels
api automerge enhancement interface op
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShawnXuan @leaves-zwx @oneflow-ci-bot