Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output arg modifier return maybe part_0 #5447

Merged
merged 4 commits into from
Jul 10, 2021

Conversation

liufengwei0103
Copy link
Contributor

@liufengwei0103 liufengwei0103 commented Jul 10, 2021

Output arg modifier return maybe - part_0:

这次pr是形成 api层到 OutputArgModifer回调函数 完整的 maybe手工栈的第一部分,共两部分。
第二部分在:#5451

完整调用链为:
api层 -> f0(如CurJobBuildAndInferCtx_AddAndInferMirroredOp) -> f1(如AddAndInferMirroredOp)-> ConstructOp -> CheckAndConstructOp -> Operator->Init() -> Init() -> InitFromOpConf() -> output_arg_modify_fn

因ConstructOp会传染较多文件,故本次pr从output_arg_modify_fn截止到CheckAndConstructOp,使用了CHECK_JUST中断了手工栈
"""
std::shared_ptr CheckAndConstructOp(std::shared_ptr op_conf) {
...
CHECK_JUST(rptr->Init(op_conf));
...
}
"""
第二部分pr形成ConstructOp到api层手工栈。

@liufengwei0103 liufengwei0103 changed the title Output arg modifier return maybe Output arg modifier return maybe part_0 Jul 10, 2021
@liufengwei0103 liufengwei0103 force-pushed the OutputArgModifier_return_maybe branch 2 times, most recently from 9c3fe8b to 3434303 Compare July 10, 2021 04:17
@liufengwei0103 liufengwei0103 requested review from lixinqi and removed request for lixinqi July 10, 2021 04:41
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 10, 2021 16:13
@oneflow-ci-bot oneflow-ci-bot merged commit 5e29d7b into master Jul 10, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the OutputArgModifier_return_maybe branch July 10, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants