Output arg modifier return maybe part 1 #5451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neflow-inc/oneflow into OutputArgModifier_return_maybe_part_1
liufengwei0103
changed the base branch from
master
to
OutputArgModifier_return_maybe
liufengwei0103
force-pushed
the
OutputArgModifier_return_maybe
branch
from
3434303
to
dc45b30
Compare
…neflow-inc/oneflow into OutputArgModifier_return_maybe_part_1 Conflicts: oneflow/core/operator/operator.cpp
liufengwei0103
force-pushed
the
OutputArgModifier_return_maybe_part_1
branch
2 times, most recently
from
a6c7220
to
c9eaa68
Compare
lixinqi
reviewed
Jul 12, 2021
| const std::string& src_lbn = | ||
| src_subset_tick_op.name() + "/" + src_subset_tick_op.src_subset_tick_conf().out(); | ||
| job_builder->ForEachOperator([&](const Operator& op) { | ||
| JUST(job_builder->ForEachOperator([&](const Operator& op) -> Maybe<void> { |
There was a problem hiding this comment.
ForEachOperator的参数是一个返回void的函数，而不是Maybe<void>
There was a problem hiding this comment.
ForEachOperator的参数是一个返回void的函数，而不是
Maybe<void>
已修改
…OutputArgModifier_return_maybe_part_1 Conflicts: oneflow/core/operator/operator.cpp
liufengwei0103
force-pushed
the
OutputArgModifier_return_maybe_part_1
branch
from
8663cac
to
9f140e1
Compare
lixinqi
approved these changes
Jul 13, 2021
liufengwei0103
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output arg modifier return maybe - part_1:
这次pr是形成 api层到 OutputArgModifer回调函数 完整的 maybe手工栈的第二部分，共两部分。
第一部分在：#5447
完整调用链为：
api层 -> f0(如CurJobBuildAndInferCtx_AddAndInferMirroredOp) -> f1(如AddAndInferMirroredOp）-> ConstructOp -> CheckAndConstructOp -> Operator->Init() -> Init() -> InitFromOpConf() -> output_arg_modify_fn
本次pr主要是从api 层 -> f0 -> f1 -> ConstructOp.
因ConstructOp会传染较多xx_task_node.cpp中的部分，xx_task_node.cpp中调用以CHECK_JUST(ConstructOp(op_conf))终止。在未来pr中再次修改。