Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added nn.RecordBytesDecoder with its test #5475

Merged
merged 51 commits into from
Aug 3, 2021
Merged

Conversation

Kevin-XiongC
Copy link
Contributor

@Kevin-XiongC Kevin-XiongC commented Jul 13, 2021

image

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021

CLA assistant check
All committers have signed the CLA.

@Kevin-XiongC Kevin-XiongC marked this pull request as draft July 13, 2021 08:16
@Kevin-XiongC Kevin-XiongC marked this pull request as ready for review July 13, 2021 08:16
@Kevin-XiongC Kevin-XiongC marked this pull request as draft July 13, 2021 08:32
@Kevin-XiongC Kevin-XiongC marked this pull request as ready for review July 13, 2021 08:35
@Kevin-XiongC Kevin-XiongC marked this pull request as draft July 13, 2021 08:35
@oneflow-ci-bot oneflow-ci-bot removed their request for review July 13, 2021 08:45
@duchengyao duchengyao requested review from simonJJJ and BBuf July 14, 2021 02:21
oneflow/python/nn/modules/dataset.py Outdated Show resolved Hide resolved
class OFRecordBytesDecoder(Module):
def __init__(self, blob_name: str,name: Optional[str] = None):
super().__init__()
self._op = (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能需要移到functor。不太确定,帮你加另一个reviewer

@oneflow-ci-bot oneflow-ci-bot self-requested a review August 2, 2021 07:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 2, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 09:51
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 11:50
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 2, 2021 14:21
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 17:27
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 2, 2021 17:27
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 2, 2021 18:32
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 2, 2021 20:35
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 3, 2021 01:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 141.9ms (= 7096.8ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.8ms (= 6337.6ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 141.9ms / 126.8ms)

PyTorch resnet50 time: 84.5ms (= 4225.2ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 73.9ms (= 3694.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.14 (= 84.5ms / 73.9ms)

PyTorch resnet50 time: 58.4ms (= 2921.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 49.3ms (= 2465.2ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.19 (= 58.4ms / 49.3ms)

PyTorch resnet50 time: 49.2ms (= 2460.2ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 41.9ms (= 2096.1ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.17 (= 49.2ms / 41.9ms)

PyTorch resnet50 time: 43.5ms (= 2175.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 42.7ms (= 2135.8ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.02 (= 43.5ms / 42.7ms)

@oneflow-ci-bot oneflow-ci-bot merged commit a1fc52d into master Aug 3, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev-bytedecoder branch August 3, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants