Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag for Optional inplace constructor #5619

Merged
merged 6 commits into from
Aug 2, 2021
Merged

Conversation

hjchen2
Copy link
Contributor

@hjchen2 hjchen2 commented Jul 27, 2021

No description provided.

@oneflow-ci-bot oneflow-ci-bot self-requested a review July 27, 2021 06:52
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot July 27, 2021 07:47
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@hjchen2 hjchen2 requested review from lixinqi and oneflow-ci-bot and removed request for oneflow-ci-bot July 27, 2021 08:24
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 146.8ms (= 7341.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.0ms (= 6299.9ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.17 (= 146.8ms / 126.0ms)

PyTorch resnet50 time: 85.2ms (= 4259.7ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.4ms (= 3721.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.14 (= 85.2ms / 74.4ms)

PyTorch resnet50 time: 56.0ms (= 2799.5ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 52.1ms (= 2604.6ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.07 (= 56.0ms / 52.1ms)

PyTorch resnet50 time: 71.7ms (= 3584.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 59.8ms (= 2987.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.20 (= 71.7ms / 59.8ms)

PyTorch resnet50 time: 47.1ms (= 2357.4ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 54.6ms (= 2727.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.86 (= 47.1ms / 54.6ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review July 27, 2021 09:51
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

CI failed, removing label automerge

@github-actions github-actions bot removed the automerge label Aug 1, 2021
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 1, 2021 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

CI failed, removing label automerge

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 141.1ms (= 7055.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 126.7ms (= 6336.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 141.1ms / 126.7ms)

PyTorch resnet50 time: 81.9ms (= 4095.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.0ms (= 3701.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.11 (= 81.9ms / 74.0ms)

PyTorch resnet50 time: 57.1ms (= 2855.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 48.6ms (= 2430.4ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.17 (= 57.1ms / 48.6ms)

PyTorch resnet50 time: 48.8ms (= 2440.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 44.6ms (= 2230.1ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 48.8ms / 44.6ms)

PyTorch resnet50 time: 39.7ms (= 1986.4ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 43.4ms (= 2170.5ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.92 (= 39.7ms / 43.4ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 2, 2021 03:28
@oneflow-ci-bot oneflow-ci-bot merged commit 2ad7b93 into master Aug 2, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_fix_optional branch August 2, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants