-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RuntimeCtx for multi-runtime #5664
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dev_cc_refactor_runtime_context
leaves-zwx
approved these changes
Jul 30, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 30, 2021 06:54
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 30, 2021 09:05
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
July 30, 2021 10:11
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
为了支持多个 Runtime 同时存在,进行一系列必要的重构。
Global<Profile>
和 试跑相关的入口代码 collect_act_event 等(ActEventLog 的逻辑没有移除,但现在不再调用了),性能调试目前有更易用的接口是: OF_PROFILER_RANGE_PUSH 等为了支持多个 Runtime,所以需要允许有相互独立的 Actor Count 的计数方式(每个 Runtime 自己需要独立计数,同时 Thread 是跨 Runtime(多job )的,所以需要在 Actor 里记录所属的 Runtime),最终为了兼容 Single-Client 和 Multi-Client 对 Runtime 的使用方式,我选择了 job_id 作为区分,并在 Actor 中记录所属的 job_id。