-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove scale arg in optimizer #5821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
L1aoXingyu
commented
Aug 10, 2021
- 移除 flow.Optim.xxx Optimizer 里的 scale 参数 定义、文档
- 移除 /test/modules/test_optim_xx 里对 scale 的测试
- 移除 /test/graph/test_graph_optimizer.py 里对 scale 的测试
chengtbf
approved these changes
Aug 10, 2021
wyg1997
approved these changes
Aug 10, 2021
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 10, 2021 07:15
Merged
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 10, 2021 08:31
wyg1997
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 10, 2021 09:06
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 10, 2021 10:25
CI failed, removing label automerge |
L1aoXingyu
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 10, 2021 14:06
strint
approved these changes
Aug 11, 2021
L1aoXingyu
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 11, 2021 02:15
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 11, 2021 02:49
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
August 11, 2021 04:34
Speed stats:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.