Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scale arg in optimizer #5821

Merged
merged 11 commits into from
Aug 11, 2021
Merged

remove scale arg in optimizer #5821

merged 11 commits into from
Aug 11, 2021

Conversation

L1aoXingyu
Copy link
Contributor

  • 移除 flow.Optim.xxx Optimizer 里的 scale 参数 定义、文档
  • 移除 /test/modules/test_optim_xx 里对 scale 的测试
  • 移除 /test/graph/test_graph_optimizer.py 里对 scale 的测试

@chengtbf chengtbf requested a review from wyg1997 August 10, 2021 06:08
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 07:15
@Ldpe2G Ldpe2G mentioned this pull request Aug 10, 2021
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 08:31
@wyg1997 wyg1997 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 09:06
@L1aoXingyu L1aoXingyu added the purge purge obsolete code label Aug 10, 2021
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 10:25
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@L1aoXingyu L1aoXingyu requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 10, 2021 14:06
@L1aoXingyu L1aoXingyu requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 02:15
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 02:15
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 11, 2021 02:16
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 02:49
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 11, 2021 04:34
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 137.8ms (= 6888.7ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 125.9ms (= 6297.0ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 137.8ms / 125.9ms)

PyTorch resnet50 time: 82.2ms (= 4107.7ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 72.9ms (= 3645.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 82.2ms / 72.9ms)

PyTorch resnet50 time: 56.1ms (= 2802.5ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.4ms (= 2369.8ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.18 (= 56.1ms / 47.4ms)

PyTorch resnet50 time: 48.6ms (= 2428.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 49.4ms (= 2472.3ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 0.98 (= 48.6ms / 49.4ms)

PyTorch resnet50 time: 40.4ms (= 2017.7ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 44.8ms (= 2239.0ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 0.90 (= 40.4ms / 44.8ms)

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 11, 2021 07:17
@oneflow-ci-bot oneflow-ci-bot merged commit d854520 into master Aug 11, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the dev_optim_scale branch August 11, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants