Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pow and logical functional apis #6032

Merged
merged 23 commits into from
Aug 26, 2021
Merged

Conversation

hjchen2
Copy link
Contributor

@hjchen2 hjchen2 commented Aug 25, 2021

No description provided.

@github-actions
Copy link
Contributor

CI failed, removing label automerge

1 similar comment
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@hjchen2 hjchen2 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 03:22
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 25, 2021 04:21
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 06:31
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 17:06
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 18:17
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 19:58
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 21:24
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 22:12
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 25, 2021 23:34
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 26, 2021 00:49
* Fix logical_or and logical_and unittest

* Rewrite clip

* Fix clamp

* reformat

* Rewrite scatter and scatter_add

* Rewrite fmod and where

* Rename clip functor by clamp
@hjchen2 hjchen2 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 26, 2021 01:41
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 26, 2021 01:57
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 26, 2021 01:58
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 140.2ms (= 7011.2ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 127.9ms (= 6393.3ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.10 (= 140.2ms / 127.9ms)

PyTorch resnet50 time: 83.3ms (= 4163.5ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.4ms (= 3717.9ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.12 (= 83.3ms / 74.4ms)

PyTorch resnet50 time: 57.7ms (= 2882.9ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.2ms (= 2360.1ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 57.7ms / 47.2ms)

PyTorch resnet50 time: 48.9ms (= 2443.7ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 39.1ms (= 1956.6ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.25 (= 48.9ms / 39.1ms)

PyTorch resnet50 time: 44.7ms (= 2235.0ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 43.2ms (= 2159.9ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.03 (= 44.7ms / 43.2ms)

@hjchen2 hjchen2 merged commit 1bb015b into master Aug 26, 2021
@hjchen2 hjchen2 deleted the dev_refactor_python_functions branch August 26, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants