Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix select_first_grad bug #6142

Merged
merged 7 commits into from
Sep 2, 2021
Merged

Fix select_first_grad bug #6142

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16ab3b2
fix(ddp): fix select_first_grad bug
wyg1997 Sep 2, 2021
61cd046
Merge branch 'master' into fix-ddp_select_first_grad
wyg1997 Sep 2, 2021
cd35d80
add check for select_first
wyg1997 Sep 2, 2021
c7c734b
Merge branch 'master' into fix-ddp_select_first_grad
wyg1997 Sep 2, 2021
c5de09c
Merge branch 'master' into fix-ddp_select_first_grad
oneflow-ci-bot Sep 2, 2021
a8e244c
Merge branch 'master' into fix-ddp_select_first_grad
oneflow-ci-bot Sep 2, 2021
d57448d
Merge branch 'master' into fix-ddp_select_first_grad
oneflow-ci-bot Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion oneflow/core/autograd/gradient_funcs/select_first.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ namespace one {

struct SelectFirstCaptureState : public AutoGradCaptureState {
TensorTuple inputs;
bool requires_grad;
std::vector<bool> requires_grad;
};

class SelectFirst : public OpExprGradFunction<SelectFirstCaptureState> {
Expand All @@ -35,13 +35,19 @@ class SelectFirst : public OpExprGradFunction<SelectFirstCaptureState> {
Maybe<void> Capture(SelectFirstCaptureState* ctx, const TensorTuple& inputs,
const TensorTuple& outputs, const AttrMap& attrs) const override {
ctx->inputs = inputs;
CHECK_OR_RETURN(ctx->inputs.at(0)->requires_grad());
ctx->requires_grad.resize(inputs.size());
for (int i = 0; i < ctx->requires_grad.size(); ++i) {
ctx->requires_grad.at(i) = inputs.at(i)->requires_grad();
}
return Maybe<void>::Ok();
}

Maybe<void> Apply(const SelectFirstCaptureState* ctx, const TensorTuple& out_grads,
TensorTuple* in_grads) const override {
in_grads->at(0) = out_grads.at(0);
for (int i = 1; i < ctx->inputs.size(); i++) {
if (!ctx->requires_grad.at(i)) { continue; }
const auto& tensor = ctx->inputs.at(i);
in_grads->at(i) = JUST(StaticZerosTensor::MakeTensor(
tensor->shape(), tensor->dtype()->data_type(), JUST(tensor->device())));
Expand Down