Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate repeat python layer to functor #7256

Closed
wants to merge 12 commits into from

Conversation

thinksoso
Copy link
Contributor

@thinksoso thinksoso commented Jan 14, 2022

作为tile算子迁移的前置任务,和tile一起pr了,此pr关闭 #7305

  1. repeat迁移functor
  2. 增加Tensor.repeat
  3. 相关文档
    image

image

std::vector<int32_t> expand_shape_vec;
std::vector<int32_t> output_reshape_vec;

int32_t diff = repeat_shape.NumAxes() - input_shape.NumAxes();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff -> numaxes_diff

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修正

@github-actions
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

@lixiang007666 lixiang007666 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 18, 2022 10:21
@lixiang007666
Copy link
Contributor

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

下次可以先 ninja of_format

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 18, 2022 13:49
@thinksoso
Copy link
Contributor Author

tile.py 里面调用 repeat 函数的方式有问题,repeat跟pytorch对齐后,应该传入的是*size,而不是tuple类型,这个分支先不合并了,等开发完tile一起合并。

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot January 18, 2022 19:08
@github-actions
Copy link
Contributor

CI failed when running job: cuda-misc. PR label automerge has been removed

@oneflow-ci-bot oneflow-ci-bot removed their request for review January 18, 2022 22:53
@thinksoso thinksoso closed this Jan 19, 2022
@chengtbf chengtbf deleted the migrate_repeat_python_layer_to_functor branch April 13, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants