Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tile python layer to functor #7305
Migrate tile python layer to functor #7305
Changes from 13 commits
d584632
5d14b4c
9fb74c7
9b5dbc8
27f33d4
bfc1a0c
ddab4cb
202915f
89d2228
7c0d7d6
1c2fd2c
9557ad6
04a86bc
eee21cb
d52d4fb
80cb2fa
9e68dcb
a8be7a5
b5033bb
66f813e
624c063
9bc8bd0
99e0a6e
ea52e8a
2e07b17
0e8cce2
5025d02
c1fdba2
d81219f
54b1158
fffcc78
1edef4c
c76f080
70ca5ce
0da0c3e
c794169
ab4218a
4cb5648
b53305f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
input->shape()->NumAxes()可以改成input->ndim()
参考这个 https://github.com/Oneflow-Inc/oneflow/blob/master/oneflow/core/framework/tensor.h#L51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的报错还不能和pytorch完全一致,因为错误判断的实现位置不同,pytorch应该是不在tile层面检查,而是下到创建tensor时检查,这里的实现和python实现一致,在tile函数中提前检查。