Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix batch gather get_sbp and add global unittest #7590

Merged
merged 7 commits into from
Feb 28, 2022

Conversation

hjchen2
Copy link
Contributor

@hjchen2 hjchen2 commented Feb 24, 2022

No description provided.

Copy link
Contributor

@wyg1997 wyg1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看 batch_gather 的文档中的示例还是用的 flow.Tensor 接口,后江可以顺手改成 flow.tensor 接口嘛

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 28, 2022 05:54
@oneflow-ci-bot oneflow-ci-bot removed their request for review February 28, 2022 06:15
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot February 28, 2022 09:08
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

✔️ OneFlow resnet50 time: 128.6ms (= 12856.4ms / 100, input_shape=[16, 3, 224, 224])
PyTorch resnet50 time: 139.1ms (= 13911.9ms / 100, input_shape=[16, 3, 224, 224])
✔️ Relative speed: 1.08 (= 139.1ms / 128.6ms)

✔️ OneFlow resnet50 time: 76.8ms (= 7678.0ms / 100, input_shape=[8, 3, 224, 224])
PyTorch resnet50 time: 84.2ms (= 8421.2ms / 100, input_shape=[8, 3, 224, 224])
✔️ Relative speed: 1.10 (= 84.2ms / 76.8ms)

OneFlow resnet50 time: 52.8ms (= 10569.7ms / 200, input_shape=[4, 3, 224, 224])
PyTorch resnet50 time: 58.7ms (= 11730.4ms / 200, input_shape=[4, 3, 224, 224])
✔️ Relative speed: 1.11 (= 58.7ms / 52.8ms)

OneFlow resnet50 time: 42.4ms (= 8481.0ms / 200, input_shape=[2, 3, 224, 224])
PyTorch resnet50 time: 48.7ms (= 9749.0ms / 200, input_shape=[2, 3, 224, 224])
✔️ Relative speed: 1.15 (= 48.7ms / 42.4ms)

OneFlow resnet50 time: 39.7ms (= 7933.8ms / 200, input_shape=[1, 3, 224, 224])
PyTorch resnet50 time: 40.5ms (= 8100.5ms / 200, input_shape=[1, 3, 224, 224])
✔️ Relative speed: 1.02 (= 40.5ms / 39.7ms)

✔️ OneFlow resnet50 time: 142.5ms (= 14253.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 160.6ms (= 16062.5ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.13 (= 160.6ms / 142.5ms)

OneFlow resnet50 time: 91.3ms (= 9129.1ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 101.9ms (= 10188.0ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.12 (= 101.9ms / 91.3ms)

OneFlow resnet50 time: 63.5ms (= 12693.5ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.2ms (= 15244.3ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 76.2ms / 63.5ms)

OneFlow resnet50 time: 53.9ms (= 10786.9ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 72.4ms (= 14473.8ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.34 (= 72.4ms / 53.9ms)

OneFlow resnet50 time: 49.3ms (= 9851.9ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 64.5ms (= 12901.5ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.31 (= 64.5ms / 49.3ms)

@hjchen2
Copy link
Contributor Author

hjchen2 commented Feb 28, 2022

我看 batch_gather 的文档中的示例还是用的 flow.Tensor 接口,后江可以顺手改成 flow.tensor 接口嘛

以后再改吧,和这个PR也没有太大联系,而且这个PR已经在跑CI了,更新了又要重新跑了

@hjchen2 hjchen2 merged commit 536d3a1 into master Feb 28, 2022
@hjchen2 hjchen2 deleted the dev_fix_get_sbp_and_add_global_batch_gather_unittest branch February 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants