-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix batch gather get_sbp and add global unittest #7590
Merged
hjchen2
merged 7 commits into
master
from
dev_fix_get_sbp_and_add_global_batch_gather_unittest
Feb 28, 2022
Merged
fix batch gather get_sbp and add global unittest #7590
hjchen2
merged 7 commits into
master
from
dev_fix_get_sbp_and_add_global_batch_gather_unittest
Feb 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyg1997
reviewed
Feb 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我看 batch_gather 的文档中的示例还是用的 flow.Tensor
接口,后江可以顺手改成 flow.tensor
接口嘛
wyg1997
approved these changes
Feb 28, 2022
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
February 28, 2022 05:54
clackhan
approved these changes
Feb 28, 2022
oneflow-ci-bot
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
February 28, 2022 09:08
Speed stats:
|
以后再改吧,和这个PR也没有太大联系,而且这个PR已经在跑CI了,更新了又要重新跑了 |
hjchen2
deleted the
dev_fix_get_sbp_and_add_global_batch_gather_unittest
branch
February 28, 2022 10:02
marigoold
pushed a commit
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.