Add adjustable PWM frequency to minimize buzzing noise #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this briefly in its current state in games/general UI stuff & works well - high pitch whine is just about gone! awesome work 👍 |
Closed
|
Not tested on MM for now. |
schmurtzm
approved these changes
Dec 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
MainUI patched to react to SIGTERM signal. A sighandler to break out of the main loop was incorrectly implemented, set up to act on SIGKILL (9) which is not possible, as SIGKILL will always kill and leave the process no time to react.  The sighandler simply sets a value which is checked early in the main `while(true)` loop This allows us to shut down MainUI gracefully by sending SIGTERM instead of SIGKILL which can cause all sorts of troubles, notably black screens. This _includes_ the patches from #1179 and thus should be merged after #1179 --------- Co-authored-by: Schmurtz <Schmurtz@gmail.com>
3 tasks
tGecko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to control the backlights PWM frequency.
This can improve the constant buzzing of the device by making it a less annoying frequency.
From my testing, at 200 Hz the buzzing is much less noticeable and there does not seem to be a negative impact on the image quality. At 100 Hz the flicker might be visible to sensitive eyes.
I would have preferred to go above the audible hearing range, but everything above 1000 Hz makes the brightness control unstable/unusable.
MainUI has been patched to not set the PWM value every time it is launched.