Fix the sighandler in MainUI #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tGecko
changed the title
tGecko
added a commit
that referenced
this pull request
Oct 18, 2023
fix no sound in tweaks add updated mainui binaries (same as #1193)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
## Needs to be merged after Mainui sig handling #1193 as it uses -2, and #1299 unless rebased after this merges (as the NUM_TOOLS needs to be updated) - Tested on MM+ FW 0628, MM 1027, MM 0611 - Tested with Sandisk Ultra cards ## Adds a tool to sort the Apps list A-Z or Z-A based on their config.json LABEL. - Will add 2 tools to the Tweaks -> Tools menu
schmurtzm
approved these changes
Dec 12, 2023
schmurtzm
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainUI patched to react to SIGTERM signal.
A sighandler to break out of the main loop was incorrectly implemented, set up to act on SIGKILL (9) which is not possible, as SIGKILL will always kill and leave the process no time to react.
The sighandler simply sets a value which is checked early in the main
while(true)loopThis allows us to shut down MainUI gracefully by sending SIGTERM instead of SIGKILL which can cause all sorts of troubles, notably black screens.
This includes the patches from #1179 and thus should be merged after #1179