Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed layout by using flex #972

Merged
merged 3 commits into from
Sep 22, 2023
Merged

feat: fixed layout by using flex #972

merged 3 commits into from
Sep 22, 2023

Conversation

web-mi
Copy link
Contributor

@web-mi web-mi commented Jul 25, 2023

Fixes #

Proposed Changes

@vi-sudo
Copy link

vi-sudo commented Jul 25, 2023

Task linked: OB-5203 Fehler auf Staging

@what-the-diff
Copy link

what-the-diff bot commented Jul 25, 2023

PR Summary

  • UI Adjustments and Code Refactoring
    Several changes were made in different files, mostly concerning CSS classes, to improve our application's layout, style and overall look. This involved removing unnecessary properties, adjusting existing ones, and implementing new styles when necessary.

  • Navigation Bar Update
    We improved the code structure in the NavigationBar.tsx file, implemented newly imported components for better efficiency, and also added a new feature that shows an indicator for unread messages. All these contribute to enhance our product's navigation user experience.

  • Implemented Route-Based Component Render
    The Routing.tsx file now contains logic that ensures different components are displayed based on the current route path helping us control user flow and enhance usability.

  • Optimizations to Navigation Handler
    This file was optimized significantly; several functions have been removed due to redundancy while others were updated to perform more efficiently and handle possible null cases.

  • Revamped Interaction with Several Views and Components
    Refactoring changes were made across different views and components like Appointments.tsx, Banner.tsx, WriteEnquiry.tsx and more. The aim was to remove redundant code, update class changes and streamline interactions.

  • Scrollable Section Update
    There were many changes in the ScrollableSection.tsx and the associated scrollableSection.styles.scss files. The goal was to enhance performance, improve scalability and remove code redundancy.

  • Session Style Changes
    There were changes in the session.styles.scss file that allowed for optimized positioning and display of different elements, contributing to a better user interface.

  • Group Chat Header Update
    Unnecessary checks to determine whether a chat is active or not were removed in GroupChatHeader/index.tsx resulting in smoother group chat interactions.

  • Inefficient Code Removal
    ToolsList.tsx file along with several other .tsx files had useEffect hook and unnecessary imports removed. This improved performance through efficient memory usage, and code scalability by reducing redundancy.

  • UserDataProvider Updates
    Certain unnecessary properties and imports were removed from UserDataProvider.tsx to ensure that the user data is handled more efficiently, simplifying our codebase and enhancing our application's speed.

  • New CSS Class Addition
    A new CSS class app__container was added in the app.html file. This was done to provide more flexibility when dealing with the structure and content of our application and enhance the UI/UX.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-mi web-mi marked this pull request as ready for review September 22, 2023 09:55
@web-mi web-mi merged commit 6217cf5 into develop Sep 22, 2023
9 checks passed
@web-mi web-mi deleted the OB-5203 branch September 22, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants