Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand and language added #12

Merged
merged 11 commits into from
Feb 4, 2015
Merged

Conversation

dieuska
Copy link
Contributor

@dieuska dieuska commented Jan 30, 2015

closed #10 and closed #11

@koenedaele
Copy link
Member

Currently the tests fail on py3.3 and py 3.4

@koenedaele
Copy link
Member

Is it possible to add a test that show the difference between the language parameter and the locale name?

Eg. a test where we set up the DummyRequest with locale_name "en", do the request. Then do the same request with parameter language "nl". And then compare both results to assert that they're different?

@koenedaele
Copy link
Member

Could you also update the service documentation?

@dieuska
Copy link
Contributor Author

dieuska commented Jan 30, 2015

allright, problem of 3.3/3.4 was the difference "import fixtures" vs "import .fixtures" and the different testing libs. I ll add the test and service documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c10695b on dieuska:master into c58f2f1 on koenedaele:master.

@dieuska
Copy link
Contributor Author

dieuska commented Jan 30, 2015

when writing the tests that you asked, I discovered a dependency to Skosprovider that we also need to adapt to fix the language-ticket:
Skosprovider->registry.py-> find(). This method also need to pass by 'language' because it is used in pyramid_skosprovider. So I first need to make a pull request for that one...

@koenedaele
Copy link
Member

Yes, that's already registered as OnroerendErfgoed/skosprovider#10.

@koenedaele
Copy link
Member

The issue in OnroerendErfgoed/skosprovider#10 has been solved.

@koenedaele koenedaele merged commit 36e7acc into OnroerendErfgoed:master Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the expand method Allow client to choose language
3 participants