-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand and language added #12
Conversation
Currently the tests fail on py3.3 and py 3.4 |
Is it possible to add a test that show the difference between the language parameter and the locale name? Eg. a test where we set up the DummyRequest with locale_name "en", do the request. Then do the same request with parameter language "nl". And then compare both results to assert that they're different? |
Could you also update the service documentation? |
allright, problem of 3.3/3.4 was the difference "import fixtures" vs "import .fixtures" and the different testing libs. I ll add the test and service documentation |
when writing the tests that you asked, I discovered a dependency to Skosprovider that we also need to adapt to fix the language-ticket: |
Yes, that's already registered as OnroerendErfgoed/skosprovider#10. |
The issue in OnroerendErfgoed/skosprovider#10 has been solved. |
closed #10 and closed #11